Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] #3874: Remove IsAssetDefinitionOwner #3979

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[refactor] #3874: Remove IsAssetDefinitionOwner #3979

merged 1 commit into from
Oct 11, 2023

Conversation

benhhack
Copy link
Contributor

@benhhack benhhack commented Oct 10, 2023 •
edited
Loading

Notes

Two previous pull requests for the issue were closed without merge because of conflicts and messy commit histories. See #3919 #3920 . I have followed all the discussed steps in #3920 but some tests (in mod.rs) are still failing.

Linked issue

This query was introduced only for the purposes of validator. Since #3442 we can use FindAssetDefinitionById to do the exact same thing.

Closes #3874

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 10, 2023
@benhhack benhhack marked this pull request as ready for review October 10, 2023 11:57
@benhhack benhhack changed the title [refactor] Remove IsAssetDefinitionOwner (response to #3874) [refactor] #3874 Remove IsAssetDefinitionOwner Oct 10, 2023
@mversic mversic changed the title [refactor] #3874 Remove IsAssetDefinitionOwner [refactor] #3874: Remove IsAssetDefinitionOwner Oct 10, 2023
@coveralls
Copy link

coveralls commented Oct 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6468999535

  • 17 of 58 (29.31%) changed or added relevant lines in 7 files are covered.
  • 6488 unchanged lines in 109 files lost coverage.
  • Overall coverage decreased (-3.4%) to 56.016%
Changes Missing Coverage Covered Lines Changed/Added Lines %
data_model/derive/src/lib.rs 0 1 0.0%
ffi/derive/src/attr_parse/getset.rs 6 7 85.71%
ffi/derive/src/attr_parse/derive.rs 3 5 60.0%
data_model/derive/src/filter.rs 0 12 0.0%
ffi/derive/src/convert.rs 5 30 16.67%
Files with Coverage Reduction New Missed Lines %
cli/src/main.rs 1 0.0%
cli/src/torii/pagination.rs 1 98.9%
config/src/torii.rs 1 96.43%
core/src/smartcontracts/isi/block.rs 1 87.5%
crypto/src/merkle.rs 1 96.23%
logger/src/lib.rs 1 95.15%
config/src/lib.rs 2 0.0%
logger/src/layer.rs 2 48.05%
cli/src/samples.rs 3 0.0%
data_model/derive/src/has_origin.rs 3 95.16%
Totals Coverage Status
Change from base Build 5423219773: -3.4%
Covered Lines: 21933
Relevant Lines: 39155
💛 - Coveralls

@mversic mversic merged commit 9b21c21 into hyperledger-iroha:iroha2-dev Oct 11, 2023
12 checks passed
6r1d pushed a commit that referenced this pull request Oct 17, 2023
@benhhack @6r1d
[refactor] #3874: Remove IsAssetDefinitionOwner (#3979)
9861f46 
Signed-off-by: benhhack <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
6r1d pushed a commit that referenced this pull request Oct 17, 2023
@benhhack @6r1d
[refactor] #3874: Remove IsAssetDefinitionOwner (#3979)
ee1d442 
Signed-off-by: benhhack <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
mversic pushed a commit that referenced this pull request Oct 17, 2023
@benhhack @mversic
[refactor] #3874: Remove IsAssetDefinitionOwner (#3979)
d2ef4ae 
Signed-off-by: benhhack <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@pesterev pesterev pesterev approved these changes

@s8sato s8sato Awaiting requested review from s8sato

@appetrosyan appetrosyan Awaiting requested review from appetrosyan

@Arjentix Arjentix Awaiting requested review from Arjentix

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis

@ilchu ilchu Awaiting requested review from ilchu

@Erigara Erigara Awaiting requested review from Erigara

@0x009922 0x009922 Awaiting requested review from 0x009922

@DCNick3 DCNick3 Awaiting requested review from DCNick3

Assignees

@pesterev pesterev

@mversic mversic

@benhhack benhhack

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benhhack @coveralls @pesterev @mversic